Sxnan commented on code in PR #24088:
URL: https://github.com/apache/flink/pull/24088#discussion_r1454790994
##########
flink-core/src/main/java/org/apache/flink/configuration/Configuration.java:
##########
Review Comment:
We should mark get/setBytes methods as `@Internal`
##########
flink-core/src/test/java/org/apache/flink/configuration/ConfigurationTest.java:
##########
@@ -554,6 +554,45 @@ void testMapParserErrorDoesNotLeakSensitiveData() {
.doesNotContain("secret_value"));
}
+ @TestTemplate
+ void testGetWithOverrideDefault() {
+ final Configuration conf = new Configuration();
Review Comment:
Should we pass the `standardYaml` parameter to construct the
`Configuration`, like the other tests do?
##########
flink-core/src/main/java/org/apache/flink/configuration/Configuration.java:
##########
@@ -179,7 +182,9 @@ public String getString(String key, String defaultValue) {
*
* @param configOption The configuration option
* @return the (default) value associated with the given config option
+ * @deprecated use {@link #get(ConfigOption)} or {@link
#getOptional(ConfigOption)}
*/
+ @Deprecated
Review Comment:
I think we can replace the `@PublicEvolving` with `@Deprecated` directly.
Same for the other methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
