BlackPigHe commented on code in PR #89: URL: https://github.com/apache/flink-connector-jdbc/pull/89#discussion_r1458592157
########## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/utils/JdbcUtils.java: ########## @@ -168,4 +168,14 @@ public static Row getPrimaryKey(Row row, int[] pkFields) { } return pkRow; } + + public static String handleDoubleQuotes(String identifier) { + String[] split = identifier.split("\\."); + StringBuilder builder = new StringBuilder(); + for (String s : split) { + builder.append("\"").append(s).append("\""); + builder.append("."); + } + return builder.deleteCharAt(builder.length() - 1).toString(); + } Review Comment: Do you think that the location of this method is not appropriate, I think it is OK, the specific escape characters of the data source in their own package implementation, there are public features to extract and did not find a better location -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org