1996fanrui opened a new pull request, #759:
URL: https://github.com/apache/flink-kubernetes-operator/pull/759

   ## What is the purpose of the change
   
   The ScalingTracking of autoscaler is wrong, it's always greater than 
AutoScalerOptions#STABILIZATION_INTERVAL.
   
   ### Reason
   
   When flink job isStabilizing, ScalingMetricCollector#updateMetrics will 
return a empty metric history. In the JobAutoScalerImpl#runScalingLogic method, 
if `collectedMetrics.getMetricHistory().isEmpty()` , we don't update the 
ScalingTracking.
   
   The default value of AutoScalerOptions#STABILIZATION_INTERVAL is 5 min, so 
the restartTime is always greater than 5 min.
   
   However, it's quick when we use rescale api.
   
   
   ## Brief change log
   
   Update the scaling tracking even if the job is stabilizing.
   
   ## Verifying this change
   
   Adding the test later.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changes to the `CustomResourceDescriptors`: 
no
     - Core observer or reconciler logic that is regularly executed: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to