[
https://issues.apache.org/jira/browse/FLINK-5058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15674188#comment-15674188
]
ASF GitHub Bot commented on FLINK-5058:
---------------------------------------
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2799
Thanks for the fix @397090770!
+1 to merge
> taskManagerMemory attribute set wrong value in FlinkShell
> ---------------------------------------------------------
>
> Key: FLINK-5058
> URL: https://issues.apache.org/jira/browse/FLINK-5058
> Project: Flink
> Issue Type: Bug
> Components: Scala Shell
> Affects Versions: 1.1.3
> Reporter: yangping wu
> Original Estimate: 8h
> Remaining Estimate: 8h
>
> In FlinkShell.scala, someone mistakenly set {{slots}} value to
> {{taskManagerMemory}} attribute as follow:
> {code}
> // set configuration from user input
> yarnConfig.jobManagerMemory.foreach((jmMem) => args ++= Seq("-yjm",
> jmMem.toString))
> yarnConfig.slots.foreach((tmMem) => args ++= Seq("-ytm", tmMem.toString))
> yarnConfig.name.foreach((name) => args ++= Seq("-ynm", name.toString))
> yarnConfig.queue.foreach((queue) => args ++= Seq("-yqu", queue.toString))
> yarnConfig.slots.foreach((slots) => args ++= Seq("-ys", slots.toString))
> {code}
> Note on the third line: {{yarnConfig.slots.foreach((tmMem) => args ++=
> Seq("-ytm", tmMem.toString))}} , we set {{slots}} value to {{-ytm}}
> attribute, the right code should be:
> {code}
> // set configuration from user input
> yarnConfig.jobManagerMemory.foreach((jmMem) => args ++= Seq("-yjm",
> jmMem.toString))
> yarnConfig.taskManagerMemory.foreach((tmMem) => args ++= Seq("-ytm",
> tmMem.toString))
> yarnConfig.name.foreach((name) => args ++= Seq("-ynm", name.toString))
> yarnConfig.queue.foreach((queue) => args ++= Seq("-yqu", queue.toString))
> yarnConfig.slots.foreach((slots) => args ++= Seq("-ys", slots.toString))
> {code}
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
