Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2653#discussion_r88477894
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/expressions/ExpressionParser.scala
---
@@ -451,6 +452,28 @@ object ExpressionParser extends JavaTokenParsers with
PackratParsers {
}
}
+ lazy val tableFunctionCall: PackratParser[LogicalNode] =
+ functionIdent ~ "(" ~ repsep(expression, ",") ~ ")" ^^ {
+ case name ~ _ ~ args ~ _ =>
UnresolvedTableFunctionCall(name.toUpperCase, args)
--- End diff --
Couldn't `UnresolvedTableFunctionCall` be an expression? It is not very
nice that we mix up expressions and logical nodes here. We also should think
about how we want to integrate IN/NOT IN in the future as we have similar
problems there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
