wangyang0918 commented on code in PR #24132: URL: https://github.com/apache/flink/pull/24132#discussion_r1467583895
########## flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesLeaderElector.java: ########## @@ -86,12 +117,38 @@ public KubernetesLeaderElector( newLeader, leaderConfig.getConfigMapName()))) .build(); + this.executorService = executorService; + + LOG.info( + "Create KubernetesLeaderElector on lock {}.", + leaderElectionConfig.getLock().describe()); + } + + @GuardedBy("lock") + private void resetInternalLeaderElector() { + stopLeaderElectionCycle(); + internalLeaderElector = new LeaderElector(kubernetesClient, leaderElectionConfig, executorService); + currentLeaderElectionSession = internalLeaderElector.start(); + LOG.info( - "Create KubernetesLeaderElector {} with lock identity {}.", - leaderConfig.getConfigMapName(), - leaderConfig.getLockIdentity()); + "Triggered leader election on lock {}.", leaderElectionConfig.getLock().describe()); + } + + @GuardedBy("lock") + private void stopLeaderElectionCycle() { + if (internalLeaderElector != null) { + Preconditions.checkNotNull(currentLeaderElectionSession); + + // the current leader election cycle needs to be cancelled before releasing the lock to + // avoid retrying + currentLeaderElectionSession.cancel(true); + currentLeaderElectionSession = null; + + internalLeaderElector.release(); Review Comment: BTW, the ITCase could also pass by using v6.6.2 with `.withReleaseOnCancel(true)` and removing `ReleaseOnCall`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org