snuyanzin commented on PR #136: URL: https://github.com/apache/flink-shaded/pull/136#issuecomment-1916671742
Thanks for your feedback @zentol I checked locally with 1.2.7 flatten plugin and confirm that it resolves the issue So I bumped the issue and currently reverted previous changes regarding shading... May be one question which is still not clear to me (not directly related to perf regression) Could you please clarify: In confluence's creating flink-shaded release page it is mentioned that we need to use maven 3.2.5 to release. Playing locally I was not able to find a difference between the result of usage 3.2.5 and 3.8.6. Do we need still apply ShadeOptionalChecker's approach like in Flink main repo to safely use 3.8.6 during release? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
