[ 
https://issues.apache.org/jira/browse/FLINK-29107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17812488#comment-17812488
 ] 

Jim Hughes commented on FLINK-29107:
------------------------------------

[~chesnay] Do you know if the IntelliJ plugin has improved in the last year?  

If so, I'd suggest we update the Maven Spotless plugin to version 2.35.0.  That 
is the last version which does not require changing the `google-java-format`. 

```
Execution default-cli of goal 
com.diffplug.spotless:spotless-maven-plugin:2.36.0:apply failed: You are 
running Spotless on JVM 11. This requires google-java-format of at least 1.8 
(you are using 1.7).
```

[~yunta] as a work around, you can add `-Dspotless.version=2.35.0` to your 
Maven commands to override the version locally. 

> Upgrade spotless version to improve spotless check efficiency
> -------------------------------------------------------------
>
>                 Key: FLINK-29107
>                 URL: https://issues.apache.org/jira/browse/FLINK-29107
>             Project: Flink
>          Issue Type: Improvement
>          Components: Build System
>    Affects Versions: 1.15.3
>            Reporter: Yu Chen
>            Assignee: Yu Chen
>            Priority: Major
>         Attachments: image-2022-08-25-22-10-54-453.png
>
>
> I noticed a [discussion|https://github.com/diffplug/spotless/issues/927] in 
> the spotless GitHub repository that we can improve the efficiency of spotless 
> checks significantly by upgrading the version of spotless and enabling the 
> `upToDateChecking`.
> I have made a simple test locally and the improvement of the spotless check 
> after the upgrade is shown in the figure.
> !image-2022-08-25-22-10-54-453.png!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to