zhuzhurk commented on code in PR #24118:
URL: https://github.com/apache/flink/pull/24118#discussion_r1472843285
##########
docs/content/docs/deployment/elastic_scaling.md:
##########
@@ -238,7 +238,7 @@ In addition, there are several related configuration
options that may need adjus
### Limitations
- **Batch jobs only**: Adaptive Batch Scheduler only supports batch jobs.
Exception will be thrown if a streaming job is submitted.
-- **BLOCKING or HYBRID jobs only**: At the moment, Adaptive Batch Scheduler
only supports jobs whose [shuffle mode]({{< ref "docs/deployment/config"
>}}#execution-batch-shuffle-mode) is `ALL_EXCHANGES_BLOCKING /
ALL_EXCHANGES_HYBRID_FULL / ALL_EXCHANGES_HYBRID_SELECTIVE`.
+- **BLOCKING or HYBRID jobs only**: At the moment, Adaptive Batch Scheduler
only supports DataStream jobs whose [shuffle mode]({{< ref
"docs/deployment/config" >}}#execution-batch-shuffle-mode) is
`ALL_EXCHANGES_BLOCKING / ALL_EXCHANGES_HYBRID_FULL /
ALL_EXCHANGES_HYBRID_SELECTIVE` and DataSet jobs whose `ExecutionMode` is
`BATCH_FORCED`.
Review Comment:
Maybe keep the original statement and add an extra statement like "Note that
for DataSet jobs, the `ExecutionMode` needs to be `BATCH_FORCED` since they do
not use the aforementioned shuffle mode".
Later in Flink 2.0, we can directly remove the extra statement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
