jeyhunkarimov commented on code in PR #24239:
URL: https://github.com/apache/flink/pull/24239#discussion_r1475765107
##########
flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/hints/batch/NestLoopJoinHintTest.xml:
##########
@@ -679,8 +680,8 @@ HashJoin(joinType=[LeftSemiJoin], where=[=(a1, a2)],
select=[a1, b1], build=[rig
+- Calc(select=[a2])
+- NestedLoopJoin(joinType=[InnerJoin], where=[=(a2, a3)], select=[a2,
a3], build=[left])
:- Exchange(distribution=[broadcast])
- : +- TableSourceScan(table=[[default_catalog, default_database, T2,
project=[a2], metadata=[]]], fields=[a2], hints=[[[ALIAS options:[T2]]]])
- +- TableSourceScan(table=[[default_catalog, default_database, T3,
project=[a3], metadata=[]]], fields=[a3], hints=[[[ALIAS options:[T3]]]])
Review Comment:
Hi, I mainly considered the other `hint`s that are part of `TableScan`. For
example,
```
LogicalSink(table=[default_catalog.default_database.ManagedTable],
fields=[a, b, c], hints=[[[OPTIONS
options:{compact.file-entries={"compact-partitions":[{"resolved-partition-spec":{"b":"0","c":"flink"},"file-entries":["/foo/bar/file"]}]},
ENRICHED_KEY=ENRICHED_VALUE, compact.file-base-path=/foo/bar}]]])
+- LogicalTableScan(table=[[default_catalog, default_database,
ManagedTable]], hints=[[[OPTIONS inheritPath:[]
options:{compact.file-entries={"compact-partitions":[{"resolved-partition-spec":{"b":"0","c":"flink"},"file-entries":["/foo/bar/file"]}]},
ENRICHED_KEY=ENRICHED_VALUE, compact.file-base-path=/foo/bar}]]])
```
. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
