mxm commented on code in PR #762:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/762#discussion_r1478006171
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/JobAutoScalerImpl.java:
##########
@@ -106,7 +107,13 @@ public void scale(Context ctx) throws Exception {
} catch (Throwable e) {
onError(ctx, autoscalerMetrics, e);
} finally {
- applyParallelismOverrides(ctx);
+ try {
+ applyParallelismOverrides(ctx);
+ applyConfigOverrides(ctx);
Review Comment:
Oh right, good point. In-place scaling won't be possible with auto tuning
because the Flink config can't be updated on the fly. We need to fall back to a
full upgrade in this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
