masteryhx commented on code in PR #24254:
URL: https://github.com/apache/flink/pull/24254#discussion_r1479468010
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointStatsTracker.java:
##########
@@ -112,8 +112,9 @@ public class CheckpointStatsTracker {
* progress ones.
* @param metricGroup Metric group for exposed metrics
*/
- public CheckpointStatsTracker(int numRememberedCheckpoints, MetricGroup
metricGroup) {
- this(numRememberedCheckpoints, metricGroup, new JobID(),
Integer.MAX_VALUE);
+ public CheckpointStatsTracker(
Review Comment:
nit: How about also adding "@param" for jobID since it has others?
Or just introducing a new method for Tests so that they could not be
modified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
