mas-chen commented on code in PR #84:
URL: 
https://github.com/apache/flink-connector-kafka/pull/84#discussion_r1482310252


##########
.github/workflows/push_pr.yml:
##########
@@ -30,6 +30,8 @@ jobs:
         include:
           - flink: 1.18.1
             jdk: '8, 11, 17'
+          - flink: 1.19-SNAPSHOT

Review Comment:
   Is this the only relevant thing in this PR? Everything else looks like 
refactoring...
   
   After https://github.com/apache/flink/pull/24249 was merged, this compiles 
which confirms no breaking changes?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to