mxm commented on code in PR #762:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/762#discussion_r1482802937
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/config/AutoScalerOptions.java:
##########
@@ -250,6 +251,31 @@ private static ConfigOptions.OptionBuilder
autoScalerConfig(String key) {
.withDescription(
"Max allowed percentage of heap usage during
scaling operations. Autoscaling will be paused if the heap usage exceeds this
threshold.");
+ public static final ConfigOption<Boolean> MEMORY_TUNING_ENABLED =
+ autoScalerConfig("memory.tuning.enabled")
+ .booleanType()
+ .defaultValue(false)
+
.withFallbackKeys(oldOperatorConfigKey("memory.tuning.enabled"))
+ .withDescription(
+ "If enabled, the initial amount of memory
specified for TaskManagers will be reduced according to the observed needs.");
+
+ public static final ConfigOption<MemorySize> MEMORY_TUNING_MIN_HEAP =
+ autoScalerConfig("memory.tuning.heap.min")
+ .memoryType()
+ .defaultValue(MemorySize.ofMebiBytes(512L))
+
.withFallbackKeys(oldOperatorConfigKey("memory.tuning.heap.min"))
+ .withDescription(
+ "The minimum amount of TaskManager memory, if
memory tuning is enabled.");
+
+ public static final ConfigOption<Boolean>
MEMORY_TUNING_TRANSFER_HEAP_TO_MANAGED =
+ autoScalerConfig("memory.tuning.heap.transfer-to-managed")
+ .booleanType()
+ .defaultValue(false)
+ .withFallbackKeys(
+
oldOperatorConfigKey("memory.tuning.heap.transfer-to-managed"))
+ .withDescription(
+ "If enabled, any reduction of heap memory will
increase the managed memory for RocksDB. RocksDB needs to be enabled.");
Review Comment:
Sounds good.
##########
flink-autoscaler/src/test/java/org/apache/flink/autoscaler/utils/ResourceCheckUtilsTest.java:
##########
@@ -32,7 +32,7 @@
class ResourceCheckUtilsTest {
@Test
- void testEstimateNumTaskSlotsAfterRescale() {
+ void estimateNumTaskSlotsAfterRescale() {
Review Comment:
Was an issue with rebasing. I'll re-add.
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/JobAutoScalerContext.java:
##########
@@ -52,19 +55,25 @@ public class JobAutoScalerContext<KEY> {
@Nullable @Getter private final JobStatus jobStatus;
+ /** The configuration derived from the current spec. */
Review Comment:
To me, the "actual" spec is that user-provided spec. Anything else is a
deployed / observed configuration which is derived from the spec. Will rephrase
to:
```suggestion
/** The configuration based on the latest user-provided spec, not the
deployed / observed configuration. */
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
