mtfelisb commented on PR #53: URL: https://github.com/apache/flink-connector-elasticsearch/pull/53#issuecomment-1935170882
> > This pull request is working on every Flink version but `1.19-SNAPSHOT` > > I'm suspecting that's because of https://issues.apache.org/jira/browse/FLINK-25857 and https://issues.apache.org/jira/browse/FLINK-33972 which have introduced new changes to the Sink API. > > > It's unclear if I should consider `1.19-SNAPSHOT` and upward only. > > There's only thing that the community agreed on and that is that the last two minor version of Flink need to be supported. At this moment of writing, that means that Flink 1.17 and Flink 1.18 need to be supported. At the moment Flink 1.19 gets officially released, we need to have a connector that supports both Flink 1.18 and Flink 1.19. > > However, that doesn't mean that connector support needs to come from one connector version. It's perfectly fine to say "There's the Flink Elastichsearch connector v3.0 that supports Flink 1.17 and 1.18, and we'll have a new Flink Elasticsearch connector v3.1 / v4.0 that supports only Flink 1.19 and upwards". It just means that there's more work involved in backporting any bugfixes (and potentially new features) to two branches. It's explained in more depth at https://cwiki.apache.org/confluence/display/FLINK/Externalized+Connector+development#ExternalizedConnectordevelopment-Support > > In this case, I do think that it would be possible to add support for Flink 1.17/1.18 and the upcoming Flink 1.19 in one branch. At least, that's also what's being tried in the Flink Kafka connector, see [apache/flink-connector-kafka#84](https://github.com/apache/flink-connector-kafka/pull/84) I understand now, it makes total sense. I appreciate the detailed information you provided, @MartijnVisser 😀 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
