zentol commented on code in PR #24292:
URL: https://github.com/apache/flink/pull/24292#discussion_r1489262074


##########
flink-rpc/flink-rpc-core/src/main/java/org/apache/flink/runtime/rpc/MainThreadValidatorUtil.java:
##########
@@ -45,11 +45,13 @@ public MainThreadValidatorUtil(RpcEndpoint endpoint) {
     public void enterMainThread() {
         assert (endpoint.currentMainThread.compareAndSet(null, 
Thread.currentThread()))
                 : "The RpcEndpoint has concurrent access from " + 
endpoint.currentMainThread.get();
+        endpoint.beforeInvocation();

Review Comment:
   Yes, because the main thread executable covers less; it doesnt capture 
anything sent directly against the rpc service's executor.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to