hanyuzheng7 commented on code in PR #22951:
URL: https://github.com/apache/flink/pull/22951#discussion_r1489798277


##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java:
##########
@@ -231,6 +232,21 @@ ANY, and(logical(LogicalTypeRoot.BOOLEAN), LITERAL)
                             
"org.apache.flink.table.runtime.functions.scalar.ArrayContainsFunction")
                     .build();
 
+    public static final BuiltInFunctionDefinition ARRAY_SORT =
+            BuiltInFunctionDefinition.newBuilder()
+                    .name("ARRAY_SORT")
+                    .kind(SCALAR)
+                    .inputTypeStrategy(
+                            or(
+                                    sequence(new 
ArrayComparableElementArgumentTypeStrategy()),
+                                    sequence(
+                                            new 
ArrayComparableElementArgumentTypeStrategy(),
+                                            logical(LogicalTypeRoot.BOOLEAN))))

Review Comment:
   The updated function signature is now `ARRAY_SORT(<array>,[, 
<sort_ascending>[, <nulls_first>]])`, where both sort_ascending and nulls_first 
parameters are optional, allowing for more flexibility in array sorting 
behavior.
   
   The description like this
   
   `Returns the array in sorted order. When only the input array is provided, 
ascending_order and null_first default to true, sorting the array in ascending 
order with NULLs at the start. True for ascending_order results in ascending 
sort with NULLs first, while false leads to descending sort with NULLs last. 
Regardless of ascending_order, null_first true places NULLs at the beginning, 
and false at the end. If any input is null, the function returns null.`
   
   
   @MartijnVisser @dawidwys 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to