1996fanrui commented on code in PR #765: URL: https://github.com/apache/flink-kubernetes-operator/pull/765#discussion_r1490275258
########## flink-autoscaler-standalone/src/main/java/org/apache/flink/autoscaler/standalone/config/AutoscalerStandaloneOptions.java: ########## @@ -109,4 +110,51 @@ private static ConfigOptions.OptionBuilder autoscalerStandaloneConfig(String key + "export the password using this environment variable.", code(STATE_STORE_TYPE.key()), code(JDBC.toString())) .build()); + + public static final ConfigOption<EventHandlerType> EVENT_HANDLER_TYPE = + autoscalerStandaloneConfig("event-handler.type") + .enumType(EventHandlerType.class) + .defaultValue(EventHandlerType.LOGGING) + .withDescription("The autoscaler event handler type."); Review Comment: We can configure them separately. ``` --autoscaler.standalone.state-store.type jdbc \ --autoscaler.standalone.event-handler.type jdbc \ ``` After users choose JDBC for them, we can reuse all jdbc related options, such as: ``` autoscaler.standalone.jdbc.username autoscaler.standalone.jdbc.url ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org