[ https://issues.apache.org/jira/browse/FLINK-34358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17818346#comment-17818346 ]
Lijie Wang edited comment on FLINK-34358 at 2/19/24 6:15 AM: ------------------------------------------------------------- The test passes in flink 1.18 but fails in flink 1.19. The root cause is that after FLINK-34316, the code that thrown this exception was not called. The exception thrown in {{JdbcDynamicTableSource.getScanRuntimeProvider}} in flink 1.18, which was omitted in FLINK-34316. Call {{executeSql}} instead of {{sqlQuery}} should fix it. I will prepare a PR soon. was (Author: wanglijie95): The test passes in flink 1.18 but fails in flink 1.19. The root cause is that after FLINK-34316, the code that caused the exception was not called. The exception thrown in {{JdbcDynamicTableSource.getScanRuntimeProvider}} in flink 1.18, which was omitted in FLINK-34316. Call {{executeSql}} instead of {{sqlQuery}} should fix it. I will prepare a PR soon. > flink-connector-jdbc nightly fails with "Expecting code to raise a throwable" > ----------------------------------------------------------------------------- > > Key: FLINK-34358 > URL: https://issues.apache.org/jira/browse/FLINK-34358 > Project: Flink > Issue Type: Bug > Components: Connectors / JDBC > Reporter: Martijn Visser > Assignee: Lijie Wang > Priority: Blocker > Labels: pull-request-available, test-stability > > https://github.com/apache/flink-connector-jdbc/actions/runs/7770283211/job/21190280602#step:14:346 > {code:java} > [INFO] Running > org.apache.flink.connector.jdbc.dialect.cratedb.CrateDBDialectTypeTest > Error: Tests run: 19, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: > 0.554 s <<< FAILURE! - in > org.apache.flink.connector.jdbc.dialect.cratedb.CrateDBDialectTypeTest > Error: > org.apache.flink.connector.jdbc.dialect.cratedb.CrateDBDialectTypeTest.testDataTypeValidate(TestItem)[19] > Time elapsed: 0.018 s <<< FAILURE! > java.lang.AssertionError: > Expecting code to raise a throwable. > [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 > s - in org.apache.flink.connector.jdbc.catalog.JdbcCatalogUtilsTest > [INFO] Running org.apache.flink.architecture.ProductionCodeArchitectureTest > [INFO] Running org.apache.flink.architecture.ProductionCodeArchitectureBase > [INFO] Running org.apache.flink.architecture.rules.ApiAnnotationRules > [INFO] Tests run: 20, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.155 > s - in org.apache.flink.connector.jdbc.dialect.JdbcDialectTypeTest > [INFO] Running org.apache.flink.architecture.TestCodeArchitectureTest > [INFO] Running org.apache.flink.architecture.TestCodeArchitectureTestBase > [INFO] Running org.apache.flink.architecture.rules.ITCaseRules > [INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.109 > s - in org.apache.flink.architecture.rules.ApiAnnotationRules > [INFO] Running org.apache.flink.architecture.rules.TableApiRules > [INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.024 > s - in org.apache.flink.architecture.rules.TableApiRules > [INFO] Running org.apache.flink.architecture.rules.ConnectorRules > [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.31 s > - in org.apache.flink.architecture.rules.ConnectorRules > [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.464 > s - in org.apache.flink.architecture.ProductionCodeArchitectureBase > [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.468 > s - in org.apache.flink.architecture.ProductionCodeArchitectureTest > [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.758 > s - in org.apache.flink.architecture.rules.ITCaseRules > [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.761 > s - in org.apache.flink.architecture.TestCodeArchitectureTestBase > [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.775 > s - in org.apache.flink.architecture.TestCodeArchitectureTest > [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 110.38 > s - in > org.apache.flink.connector.jdbc.databases.oracle.xa.OracleExactlyOnceSinkE2eTest > [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: > 172.591 s - in > org.apache.flink.connector.jdbc.databases.db2.xa.Db2ExactlyOnceSinkE2eTest > [INFO] > [INFO] Results: > [INFO] > Error: Failures: > Error: > PostgresDialectTypeTest>JdbcDialectTypeTest.testDataTypeValidate:102 > Expecting code to raise a throwable. > Error: TrinoDialectTypeTest>JdbcDialectTypeTest.testDataTypeValidate:102 > Expecting code to raise a throwable. > Error: CrateDBDialectTypeTest>JdbcDialectTypeTest.testDataTypeValidate:102 > Expecting code to raise a throwable. > [INFO] > Error: Tests run: 394, Failures: 3, Errors: 0, Skipped: 1 > {code} -- This message was sent by Atlassian Jira (v8.20.10#820010)