Zakelly commented on code in PR #24274:
URL: https://github.com/apache/flink/pull/24274#discussion_r1494398734
##########
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBNativeMetricOptions.java:
##########
@@ -262,6 +262,27 @@ public class RocksDBNativeMetricOptions implements
Serializable {
.withDescription(
"Monitor the total count of block cache misses in
RocksDB (BLOCK_CACHE_MISS == BLOCK_CACHE_INDEX_MISS + BLOCK_CACHE_FILTER_MISS +
BLOCK_CACHE_DATA_MISS).");
+ public static final ConfigOption<Boolean> MONITOR_BLOOM_FILTER_USEFUL =
+
ConfigOptions.key("state.backend.rocksdb.metrics.bloom-filter-useful")
+ .booleanType()
+ .defaultValue(false)
+ .withDescription(
+ "Monitor the total count of bloom filter has
avoided file reads.");
+
+ public static final ConfigOption<Boolean>
MONITOR_BLOOM_FILTER_FULL_POSITIVE =
+
ConfigOptions.key("state.backend.rocksdb.metrics.bloom-filter-full-positive")
+ .booleanType()
+ .defaultValue(false)
+ .withDescription(
+ "Monitor the total count of bloom FullFilter has
not avoided the reads.");
+
+ public static final ConfigOption<Boolean>
MONITOR_BLOOM_FILTER_FULL_TRUE_POSITIVE =
+
ConfigOptions.key("state.backend.rocksdb.metrics.bloom-filter-full-true-positive")
+ .booleanType()
+ .defaultValue(false)
+ .withDescription(
+ "Monitor the total count of bloom FullFilter has
not avoided the reads and data actually exist.");
Review Comment:
I would suggest a refine, such as "Monitor the count of reads avoided by
full filter while the data actually exists in RocksDB".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
