lincoln-lil commented on PR #24121: URL: https://github.com/apache/flink/pull/24121#issuecomment-1953417819
@twalthr Thank you for reviewing this! Yes, some work was needed to make it more readable, the original scala version use the same case branch style as FlinkChangelogModeInferenceProgram, but the specific logic of Ndu was too detailed, and the if-else nesting was even deeper in the java rewritten version. Will find some time to do the refactor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
