mxm commented on code in PR #782:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/782#discussion_r1500791117
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/topology/VertexInfo.java:
##########
@@ -22,17 +22,19 @@
import lombok.Data;
-import java.util.Set;
+import java.util.Map;
/** Job vertex information. */
@Data
public class VertexInfo {
private final JobVertexID id;
- private final Set<JobVertexID> inputs;
+ // All input vertices and the ship_strategy
+ private final Map<JobVertexID, String> inputs;
- private Set<JobVertexID> outputs;
+ // All output vertices and the ship_strategy
+ private Map<JobVertexID, String> outputs;
Review Comment:
It would depend on the hashCode / equals implementation, but the same issue
arrises with Map in case of duplicate JobVertexID, only that they would be
silently overwritten. Let's keep it unchanged for now.
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/tuning/MemoryTuning.java:
##########
@@ -277,6 +286,32 @@ private static MemorySize adjustNetworkMemory(
return new MemorySize(memBudget.budget(maxNetworkMemory));
}
+ /**
+ * Calculate how many network segment current vertex needs.
+ *
+ * @param currentVertexParallelism The parallelism of current vertex.
+ * @param otherVertexParallelism The parallelism of other vertex.
+ */
+ @VisibleForTesting
+ static int calculateNetworkSegmentNumber(
+ int currentVertexParallelism,
+ int otherVertexParallelism,
+ String shipStrategy,
+ int buffersPerChannel,
+ int floatingBuffers) {
+ // TODO When the parallelism is changed via the rescale api, the
FORWARD may be changed to
+ // RESCALE. This logic may needs to be updated after FLINK-33123.
+ if (currentVertexParallelism == otherVertexParallelism &&
"FORWARD".equals(shipStrategy)) {
+ return buffersPerChannel + floatingBuffers;
+ } else if ("FORWARD".equals(shipStrategy) ||
"RESCALE".equals(shipStrategy)) {
Review Comment:
Got it, that makes sense. So the toString() can't be overwritten by users to
shadow the built-in ones.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
