z3d1k commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1501901973
########## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/http/PrometheusAsyncHttpClientBuilder.java: ########## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.prometheus.sink.http; + +import org.apache.flink.connector.prometheus.sink.SinkMetrics; +import org.apache.flink.util.Preconditions; + +import org.apache.hc.client5.http.config.TlsConfig; +import org.apache.hc.client5.http.impl.async.CloseableHttpAsyncClient; +import org.apache.hc.client5.http.impl.async.HttpAsyncClients; +import org.apache.hc.client5.http.impl.nio.PoolingAsyncClientConnectionManagerBuilder; +import org.apache.hc.core5.http2.HttpVersionPolicy; +import org.apache.hc.core5.reactor.IOReactorConfig; +import org.apache.hc.core5.util.Timeout; + +import java.io.Serializable; +import java.util.Optional; + +/** + * Builder for async http client that will retry, based on the {@link RemoteWriteRetryStrategy} + * specified. + */ +public class PrometheusAsyncHttpClientBuilder implements Serializable { + public static final int DEFAULT_SOCKET_TIMEOUT_MS = 5000; + + private final RetryConfiguration retryConfiguration; + private Integer socketTimeoutMs; + + public PrometheusAsyncHttpClientBuilder(RetryConfiguration retryConfiguration) { + this.retryConfiguration = retryConfiguration; + } + + public PrometheusAsyncHttpClientBuilder setSocketTimeout(int socketTimeoutMs) { + this.socketTimeoutMs = socketTimeoutMs; + return this; + } + + public CloseableHttpAsyncClient buildAndStartClient(SinkMetrics counters) { + int actualSocketTimeoutMs = + Optional.ofNullable(socketTimeoutMs).orElse(DEFAULT_SOCKET_TIMEOUT_MS); + + Preconditions.checkArgument( + retryConfiguration.getInitialRetryDelayMS() >= 0, + "Initial retry delay must be >= 0"); + Preconditions.checkArgument( + retryConfiguration.getMaxRetryDelayMS() + >= retryConfiguration.getInitialRetryDelayMS(), + "Max retry delay must be >= initial retry delay"); + Preconditions.checkArgument( + retryConfiguration.getMaxRetryCount() >= 0, "Max retry count must be >= 0"); + Preconditions.checkArgument(actualSocketTimeoutMs >= 0, "Socket timeout must be >= 0"); + + final IOReactorConfig ioReactorConfig = + IOReactorConfig.custom() + .setIoThreadCount(1) // Always one thread + .setSoTimeout(Timeout.ofMilliseconds(actualSocketTimeoutMs)) + .build(); + + var client = + HttpAsyncClients.custom() + .setConnectionManager( + PoolingAsyncClientConnectionManagerBuilder.create() + .setDefaultTlsConfig( + TlsConfig.custom() + .setVersionPolicy( + HttpVersionPolicy.FORCE_HTTP_1) + .build()) + .build()) Review Comment: Should this part be extracted into variable to avoid deep nesting? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
