zentol commented on code in PR #38:
URL:
https://github.com/apache/flink-connector-shared-utils/pull/38#discussion_r1502941159
##########
_utils.sh:
##########
@@ -68,4 +68,15 @@ function set_pom_version {
new_version=$1
${MVN} org.codehaus.mojo:versions-maven-plugin:2.8.1:set
-DnewVersion=${new_version} -DgenerateBackupPoms=false --quiet
+}
+
+function is_flink_version_set_in_pom {
+ set +u
+ version=$(${MVN} help:evaluate -Dexpression="flink.version" -q -DforceStdout)
+ if [ -n "${version}" ]; then
Review Comment:
> the script is made for connectors releases only
Sort of. The connectors were an opportunity to start a new collection of
release scripts, and not carry forward issues that exist in the Flink ones.
The goal is definitely to use these for Flink at some point too. In some
ways the connectors are just a test bed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
