xuyangzhong commented on code in PR #24290:
URL: https://github.com/apache/flink/pull/24290#discussion_r1503596812
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/harness/GroupAggregateHarnessTest.scala:
##########
@@ -220,6 +225,63 @@ class GroupAggregateHarnessTest(mode: StateBackendMode,
miniBatch: MiniBatchMode
testHarness.close()
}
+ @TestTemplate
+ def testGlobalAggregateWithRetraction(): Unit = {
+ if (!this.miniBatch.on) {
+ return
+ }
+ val data = new mutable.MutableList[(String, String, Long)]
+ val t = env.fromCollection(data).toTable(tEnv, 'a, 'b, 'c)
+ tEnv.createTemporaryView("T", t)
+
+ val sql =
+ """
+ |SELECT a, SUM(c)
+ |FROM (
+ | SELECT a, b, SUM(c) as c
+ | FROM T GROUP BY a, b
+ |)GROUP BY a
+ """.stripMargin
+ val t1 = tEnv.sqlQuery(sql)
+
+ tEnv.getConfig.setIdleStateRetention(Duration.ofSeconds(2))
+ tEnv.getConfig.set("table.optimizer.agg-phase-strategy", "TWO_PHASE")
Review Comment:
Nit: use `TABLE_OPTIMIZER_AGG_PHASE_STRATEGY` instead of
`table.optimizer.agg-phase-strategy` here
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/harness/GroupAggregateHarnessTest.scala:
##########
@@ -151,8 +152,12 @@ class GroupAggregateHarnessTest(mode: StateBackendMode,
miniBatch: MiniBatchMode
expectedOutput.add(binaryRecord(UPDATE_BEFORE, "bbb", 2L: JLong))
expectedOutput.add(binaryRecord(UPDATE_AFTER, "bbb", 5L: JLong))
- val result = testHarness.getOutput
+ // accumulate
+ testHarness.processElement(binaryRecord(INSERT, "aaa", 0L: JLong))
Review Comment:
Nit: Do you think we need to add tests to cover the logic about
`stateRetentionTime = 0`? The choice is yours.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
