1996fanrui opened a new pull request, #24388: URL: https://github.com/apache/flink/pull/24388
## What is the purpose of the change [FLINK-32570](https://issues.apache.org/jira/browse/FLINK-32570) deprecated the Time class and refactor all Public or PublicEvolving apis to use the Java's Duration. StateTtlConfig.Builder#cleanupInRocksdbCompactFilter is still using the Time class. In general, we expect: - Mark it as `@Deprecated` - Provide a new cleanupInRocksdbCompactFilter(long, Duration) But I found this method is introduced in 1.19 (FLINK-30854), so a better solution may be: only provide `cleanupInRocksdbCompactFilter(long, Duration)` and don't use Time. The deprecated Api should be keep for 2 minor version. IIUC, we cannot remove Time related class if we don't deprecate it in 1.19. If so, I think this PR should be merged in 1.19.0 as well. ## Brief change log [FLINK-34522][core] Changing the Time to Duration for StateTtlConfig.Builder.cleanupInRocksdbCompactFilter -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
