1996fanrui commented on PR #24387: URL: https://github.com/apache/flink/pull/24387#issuecomment-1966071598
> Thanks for the clarification, @1996fanrui . I didn't check the history, before, but verified now that the changes were introduced with [FLINK-30854](https://issues.apache.org/jira/browse/FLINK-30854) which made it into 1.19. > > I also brought this topic up in [today's Flink 1.19 release sync](https://cwiki.apache.org/confluence/display/FLINK/1.19+Release#id-1.19Release-02/27/2024). The release managers are aware of this change and ok with merging it. 👍 Thank you very much for mentioning it in release meeting and quick feedback. > I also noticed that we didn't address Python API when deprecating the Time classes in [FLINK-32570](https://issues.apache.org/jira/browse/FLINK-32570). I created [FLINK-34527](https://issues.apache.org/jira/browse/FLINK-34527) to address this in 1.20. > > I have two minor comments on this PR. PTAL. > The Python sample code should be updated as well I didn't change it due to we didn't deprecate Time in Python api so far. I think this is exactly what FLINK-34527 wants to do. IIUC, it's better to finish it in FLINK-34527, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
