[
https://issues.apache.org/jira/browse/FLINK-34522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821648#comment-17821648
]
lincoln lee commented on FLINK-34522:
-------------------------------------
[~mapohl] I contacted [~dianfu] offline today and he'll take a look as soon as
he can.
> StateTtlConfig#cleanupInRocksdbCompactFilter still uses the deprecated Time
> class
> ---------------------------------------------------------------------------------
>
> Key: FLINK-34522
> URL: https://issues.apache.org/jira/browse/FLINK-34522
> Project: Flink
> Issue Type: Improvement
> Components: API / Core
> Affects Versions: 1.19.0
> Reporter: Rui Fan
> Assignee: Rui Fan
> Priority: Blocker
> Labels: pull-request-available
> Fix For: 1.19.0, 1.20.0
>
>
> FLINK-32570 deprecated the Time class and refactor all Public or
> PublicEvolving apis to use the Java's Duration.
> StateTtlConfig.Builder#cleanupInRocksdbCompactFilter is still using the Time
> class. In general, we expect:
> * Mark {{cleanupInRocksdbCompactFilter(long, Time)}} as {{@Deprecated}}
> * Provide a new cleanupInRocksdbCompactFilter(long, Duration)
> Note: This is exactly what FLINK-32570 does, so I guess FLINK-32570 missed
> cleanupInRocksdbCompactFilter.
> But I found this method is introduced in 1.19(FLINK-30854), so a better
> solution may be: only provide cleanupInRocksdbCompactFilter(long, Duration)
> and don't use Time.
> The deprecated Api should be keep for 2 minor version. IIUC, we cannot remove
> Time related class in Flink 2.0 if we don't deprecate it in 1.19. If so, I
> think it's better to merge this JIRA in 1.19.0 as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
