jeyhunkarimov commented on code in PR #24411:
URL: https://github.com/apache/flink/pull/24411#discussion_r1508294826
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/utils/TableTestBase.scala:
##########
@@ -1824,6 +1826,11 @@ object TableTestUtil {
s.replaceAll("\"id\"\\s*:\\s*\\d+", "\"id\" : ").trim
}
+ /** JobJson {jid} is ignored. */
+ def replaceJobId(s: String): String = {
+ s.replaceAll("\"jid\"\\s*:\\s*\"[\\w.-]*\"", "\"jid\":\"\"").trim
Review Comment:
This might also replace a string literal having `"jid..."` pattern. We
should make sure that only field values are targeted in this case
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/utils/TableTestBase.scala:
##########
@@ -1093,6 +1093,8 @@ abstract class TableTestUtilBase(test: TableTestBase,
isStreamingMode: Boolean)
case ExplainDetail.ESTIMATED_COST => replaceEstimatedCost(result)
case ExplainDetail.JSON_EXECUTION_PLAN =>
replaceNodeIdInOperator(replaceStreamNodeId(replaceStageId(result)))
+ case ExplainDetail.JSON_JOB_PLAN =>
Review Comment:
I would leave the old test as it is, and add your cases in another test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
