[ 
https://issues.apache.org/jira/browse/FLINK-20392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823188#comment-17823188
 ] 

Lorenzo Affetti commented on FLINK-20392:
-----------------------------------------

[~mapohl] [~jark] 

In order to better understand the current status of this issue and of the 
codebase as well nowadays:

As the code of the PR linked above 
([https://github.com/apache/flink/pull/14085]) does not exist anymore (I think 
the major PR to move it was this one: 
[https://github.com/apache/flink/pull/17892),] I will proceed following [this 
example|[https://github.com/apache/flink/blob/4595762f974f03bdf5a4c3d42e211c3a24604bd4/flink-end-to-end-tests/flink-sql-client-test/src/test/java/SqlClientITCase.java]],
 that uses 
[FlinkContainers|[https://github.com/apache/flink/blob/d6c7eee8243b4fe3e593698f250643534dc79cb5/flink-test-utils-parent/flink-connector-test-utils/src/main/java/org/apache/flink/connector/testframe/container/FlinkContainers.java]].

I think the goal of these IT tests is to actually spawn a Flink cluster via 
testcontainers (as `FlinkContainers` does) and required dependencies as well 
(e.g.: Kafka, etc.) and run the tests.

Do you have any feedback on this?

 

Thank you

> Migrating bash e2e tests to Java/Docker
> ---------------------------------------
>
>                 Key: FLINK-20392
>                 URL: https://issues.apache.org/jira/browse/FLINK-20392
>             Project: Flink
>          Issue Type: Technical Debt
>          Components: Test Infrastructure, Tests
>            Reporter: Matthias Pohl
>            Priority: Minor
>              Labels: auto-deprioritized-major, auto-deprioritized-minor, 
> starter
>
> This Jira issue serves as an umbrella ticket for single e2e test migration 
> tasks. This should enable us to migrate all bash-based e2e tests step-by-step.
> The goal is to utilize the e2e test framework (see 
> [flink-end-to-end-tests-common|https://github.com/apache/flink/tree/master/flink-end-to-end-tests/flink-end-to-end-tests-common]).
>  Ideally, the test should use Docker containers as much as possible 
> disconnect the execution from the environment. A good source to achieve that 
> is [testcontainers.org|https://www.testcontainers.org/].
> The related ML discussion is [Stop adding new bash-based e2e tests to 
> Flink|http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-Stop-adding-new-bash-based-e2e-tests-to-Flink-td46607.html].



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to