Zakelly commented on code in PR #24402:
URL: https://github.com/apache/flink/pull/24402#discussion_r1515510403
##########
flink-runtime/src/main/java/org/apache/flink/runtime/state/LocalBackupAndRecoveryDirectoryProvider.java:
##########
@@ -48,7 +48,7 @@
*
* <p>
*/
-public interface LocalRecoveryDirectoryProvider extends Serializable {
+public interface LocalBackupAndRecoveryDirectoryProvider extends Serializable {
Review Comment:
The 'backup' means the copy of snapshot here, not do local backup in a
narrow sense. local-recovery is omitted form 'recovery from a local backup',
also needs a place providing the local backup. So I think local backup is a
precise description for this usage. Well I agree to add 'Snapshot' here,
'SnapshotLocalBackupDirectoryProvider' or 'LocalSnapshotBackupDirectory' is
fine with me. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
