hejufang commented on code in PR #24322:
URL: https://github.com/apache/flink/pull/24322#discussion_r1518860909
##########
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBProperty.java:
##########
@@ -31,55 +31,86 @@
*/
@Internal
public enum RocksDBProperty {
- NumImmutableMemTable("num-immutable-mem-table"),
- MemTableFlushPending("mem-table-flush-pending"),
- CompactionPending("compaction-pending"),
- BackgroundErrors("background-errors"),
- CurSizeActiveMemTable("cur-size-active-mem-table"),
- CurSizeAllMemTables("cur-size-all-mem-tables"),
- SizeAllMemTables("size-all-mem-tables"),
- NumEntriesActiveMemTable("num-entries-active-mem-table"),
- NumEntriesImmMemTables("num-entries-imm-mem-tables"),
- NumDeletesActiveMemTable("num-deletes-active-mem-table"),
- NumDeletesImmMemTables("num-deletes-imm-mem-tables"),
- EstimateNumKeys("estimate-num-keys"),
- EstimateTableReadersMem("estimate-table-readers-mem"),
- NumSnapshots("num-snapshots"),
- NumLiveVersions("num-live-versions"),
- EstimateLiveDataSize("estimate-live-data-size"),
- TotalSstFilesSize("total-sst-files-size"),
- LiveSstFilesSize("live-sst-files-size"),
- EstimatePendingCompactionBytes("estimate-pending-compaction-bytes"),
- NumRunningCompactions("num-running-compactions"),
- NumRunningFlushes("num-running-flushes"),
- ActualDelayedWriteRate("actual-delayed-write-rate"),
- IsWriteStopped("is-write-stopped"),
- BlockCacheCapacity("block-cache-capacity"),
- BlockCacheUsage("block-cache-usage"),
- BlockCachePinnedUsage("block-cache-pinned-usage");
+ NumImmutableMemTable("num-immutable-mem-table", "number"),
+ MemTableFlushPending("mem-table-flush-pending", "number"),
+ CompactionPending("compaction-pending", "number"),
+ BackgroundErrors("background-errors", "number"),
+ CurSizeActiveMemTable("cur-size-active-mem-table", "number"),
+ CurSizeAllMemTables("cur-size-all-mem-tables", "number"),
+ SizeAllMemTables("size-all-mem-tables", "number"),
+ NumEntriesActiveMemTable("num-entries-active-mem-table", "number"),
+ NumEntriesImmMemTables("num-entries-imm-mem-tables", "number"),
+ NumDeletesActiveMemTable("num-deletes-active-mem-table", "number"),
+ NumDeletesImmMemTables("num-deletes-imm-mem-tables", "number"),
+ EstimateNumKeys("estimate-num-keys", "number"),
+ EstimateTableReadersMem("estimate-table-readers-mem", "number"),
+ NumSnapshots("num-snapshots", "number"),
+ NumLiveVersions("num-live-versions", "number"),
+ EstimateLiveDataSize("estimate-live-data-size", "number"),
+ TotalSstFilesSize("total-sst-files-size", "number"),
+ LiveSstFilesSize("live-sst-files-size", "number"),
+ EstimatePendingCompactionBytes("estimate-pending-compaction-bytes",
"number"),
+ NumRunningCompactions("num-running-compactions", "number"),
+ NumRunningFlushes("num-running-flushes", "number"),
+ ActualDelayedWriteRate("actual-delayed-write-rate", "number"),
+ IsWriteStopped("is-write-stopped", "number"),
+ BlockCacheCapacity("block-cache-capacity", "number"),
+ BlockCacheUsage("block-cache-usage", "number"),
+ BlockCachePinnedUsage("block-cache-pinned-usage", "number"),
+ NumFilesAtLevel("num-files-at-level", "string");
private static final String ROCKS_DB_PROPERTY_FORMAT = "rocksdb.%s";
private static final String CONFIG_KEY_FORMAT =
"state.backend.rocksdb.metrics.%s";
- private final String property;
+ private final String propertyName;
- RocksDBProperty(String property) {
- this.property = property;
+ private final String type;
Review Comment:
@Zakelly Thanks for your remind, I have changed it to enum class. Please
review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
