[
https://issues.apache.org/jira/browse/FLINK-5075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15686816#comment-15686816
]
ASF GitHub Bot commented on FLINK-5075:
---------------------------------------
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2822#discussion_r89119126
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
---
@@ -283,7 +285,7 @@ public String getShardIterator(KinesisStreamShard
shard, String shardIteratorTyp
* @param startShardId which shard to start with for this describe
operation (earlier shard's infos will not appear in result)
* @return the result of the describe stream operation
*/
- private DescribeStreamResult describeStream(String streamName, String
startShardId) throws InterruptedException {
+ private DescribeStreamResult describeStream(String streamName,
@Nullable String startShardId) throws InterruptedException {
--- End diff --
Only Kinesis does. Kinesalite incorrectly ignores `startShardId`.
It's marked `Nullable` here, because on fresh startups this method will be
called with a `null` as the start ID (on startup there will be no shard Id to
start from).
> Kinesis consumer incorrectly determines shards as newly discovered when
> tested against Kinesalite
> -------------------------------------------------------------------------------------------------
>
> Key: FLINK-5075
> URL: https://issues.apache.org/jira/browse/FLINK-5075
> Project: Flink
> Issue Type: Bug
> Components: Kinesis Connector
> Reporter: Tzu-Li (Gordon) Tai
> Assignee: Tzu-Li (Gordon) Tai
>
> A user reported that when our Kinesis connector is used against Kinesalite
> (https://github.com/mhart/kinesalite), we're incorrectly determining already
> found shards as newly discovered:
> http://apache-flink-user-mailing-list-archive.2336050.n4.nabble.com/Subtask-keeps-on-discovering-new-Kinesis-shard-when-using-Kinesalite-td10133.html
> I suspect the problem to be the mock Kinesis API implementations of
> Kinesalite doesn't completely match with the official AWS Kinesis behaviour.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
