reswqa commented on code in PR #39: URL: https://github.com/apache/flink-connector-opensearch/pull/39#discussion_r1522556968
########## flink-connector-opensearch/archunit-violations/4382f1f0-807a-45ff-97d8-42f72b6e9484: ########## @@ -14,23 +14,5 @@ org.apache.flink.connector.opensearch.table.OpensearchDynamicSinkITCase does not * reside in a package 'org.apache.flink.runtime.*' and contain any fields that are static, final, and of type InternalMiniClusterExtension and annotated with @RegisterExtension\ * reside outside of package 'org.apache.flink.runtime.*' and contain any fields that are static, final, and of type MiniClusterExtension and annotated with @RegisterExtension\ * reside in a package 'org.apache.flink.runtime.*' and is annotated with @ExtendWith with class InternalMiniClusterExtension\ -* reside outside of package 'org.apache.flink.runtime.*' and is annotated with @ExtendWith with class MiniClusterExtension\ Review Comment: IIRC, these redundant lines are the magic that make `archuint` work on both 1.17 and 1.18. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org