Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2836#discussion_r89129818
  
    --- Diff: pom.xml ---
    @@ -955,9 +996,10 @@ under the License.
                                        
<reuseForks>${flink.reuseForks}</reuseForks>
                                        <systemPropertyVariables>
                                                
<forkNumber>0${surefire.forkNumber}</forkNumber>
    +                                           
<mvn.forkNumber>0${surefire.forkNumber}</mvn.forkNumber>
                                                
<log4j.configuration>${log4j.configuration}</log4j.configuration>
                                        </systemPropertyVariables>
    -                                   <argLine>-Xms256m -Xmx800m 
-Dmvn.forkNumber=${surefire.forkNumber} -XX:-UseGCOverheadLimit</argLine>
    +                                   <!-- Do not define argLine here. See 
http://www.eclemma.org/jacoco/trunk/doc/prepare-agent-mojo.html -->
    --- End diff --
    
    That's bound to cause problems because a lot of code assumes these 
arguments here. We shouldn't touch them and instead do as the documentation you 
linked suggested:
    
    
    
    One of the ways to do this in case of maven-surefire-plugin - is to use 
syntax for late property evaluation:
    
    ```xml
    <argLine>@{argLine} -Xms256m -Xmx800m 
-Dmvn.forkNumber=${surefire.forkNumber} -XX:-UseGCOverheadLimit</argLine>
    ```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to