robobario commented on code in PR #24491: URL: https://github.com/apache/flink/pull/24491#discussion_r1525716429
########## flink-end-to-end-tests/test-scripts/common_s3_operations.sh: ########## @@ -58,7 +64,11 @@ function aws_cli_stop() { if [[ $AWSCLI_CONTAINER_ID ]]; then aws_cli_stop fi -aws_cli_start +aws_cli_start || aws_cli_start Review Comment: I'm assuming that `docker run -d ...` with detach did not create a container if the exit code is non-zero. So failed `aws_cli_start` shouldn't leave something to be cleaned. But I can't find docs stating that. Happy to remove the retry, getting the test to fail faster with a more obvious cause is an improvement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org