Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2732#discussion_r89140321
  
    --- Diff: 
flink-clients/src/main/java/org/apache/flink/client/RemoteExecutor.java ---
    @@ -207,14 +207,23 @@ public JobExecutionResult 
executePlanWithJars(JobWithJars program) throws Except
                                shutDownAtEnd = false;
                        }
     
    -                   try {
    -                           return client.run(program, 
defaultParallelism).getJobExecutionResult();
    -                   }
    -                   finally {
    -                           if (shutDownAtEnd) {
    -                                   stop();
    -                           }
    -                   }
    +                   final JobClient jobClient = client.run(program, 
defaultParallelism);
    +
    +                   jobClient.addFinalizer(
    +                           new Runnable() {
    +                                   @Override
    +                                   public void run() {
    +                                           if (shutDownAtEnd) {
    +                                                   try {
    +                                                           stop();
    +                                                   } catch (Exception e) {
    +                                                           throw new 
RuntimeException("Failed to clean up.", e);
    --- End diff --
    
    Fine, then we need something like Runnable with a checked exception 
signature.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to