snuyanzin commented on code in PR #2:
URL:
https://github.com/apache/flink-connector-jdbc/pull/2#discussion_r1528634655
##########
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/xa/JobSubtask.java:
##########
@@ -0,0 +1,50 @@
+package org.apache.flink.connector.jdbc.xa;
+
+import org.apache.flink.api.common.functions.RuntimeContext;
+import org.apache.flink.api.connector.sink2.Sink;
+
+import java.io.Serializable;
+
+/** Job identifier. */
+public class JobSubtask implements Serializable {
Review Comment:
```suggestion
@Internal
class JobSubtask implements Serializable {
```
i guess we need to mark it internal and harden modifier especially to
prevent case when someone modifies content of byte array `jobId`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
