z3d1k commented on code in PR #133:
URL:
https://github.com/apache/flink-connector-aws/pull/133#discussion_r1531899935
##########
flink-python/dev/integration_test.sh:
##########
@@ -41,10 +41,5 @@ FLINK_PYTHON_DIR=$(dirname "$CURRENT_DIR")
# set the FLINK_TEST_LIB_DIR to
"<root-project-folder>/flink-connector-aws/flink-python-connector-aws/target/dep..."
export FLINK_TEST_LIBS="${FLINK_PYTHON_DIR}/target/test-dependencies/*"
-# Temporarily update the installed 'pyflink_gateway_server.py' files with the
new one
-# Needed only until Flink 1.19 release
-echo "Checking ${FLINK_PYTHON_DIR} for 'pyflink_gateway_server.py'"
-find "${FLINK_PYTHON_DIR}/.tox" -name pyflink_gateway_server.py -exec cp
"${FLINK_PYTHON_DIR}/pyflink/pyflink_gateway_server.py" {} \;
Review Comment:
Removed to use `pyflink_gateway_server.py` provided by pyflink instead of
local copy.
##########
flink-python/tox.ini:
##########
@@ -21,7 +21,7 @@
# in multiple virtualenvs. This configuration file will run the
# test suite on all supported python versions.
# new environments will be excluded by default unless explicitly added to
envlist.
-envlist = {py37, py38, py39, py310}-cython
Review Comment:
The current fix does not work for python 3.7 because there is no 1.19
package released for this python version.
Since dependency on `apache-flink` python package is set as
`apache-flink>=1.17.0` - only the latest available Flink version is used during
testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
