vahmed-hamdy commented on code in PR #132:
URL:
https://github.com/apache/flink-connector-aws/pull/132#discussion_r1533542650
##########
flink-connector-aws/flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/table/util/KinesisStreamsConnectorOptionsUtils.java:
##########
@@ -148,13 +149,13 @@ public static class KinesisProducerOptionsMapper {
public KinesisProducerOptionsMapper(
ReadableConfig tableOptions, Map<String, String>
resolvedOptions) {
this.tableOptions = tableOptions;
- this.resolvedOptions = resolvedOptions;
+ this.resolvedOptions = new HashMap<>(resolvedOptions);
}
@VisibleForTesting
public KinesisProducerOptionsMapper(Map<String, String> allOptions) {
Review Comment:
The constructor is used differently, the one with `allOPtions` should
contain both `tableOptions` and `resolvedOptions`. you can see it is parsed
into both in this constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
