masteryhx commented on code in PR #24461:
URL: https://github.com/apache/flink/pull/24461#discussion_r1535027271
##########
flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/source/reader/CoordinatedSourceRescaleITCase.java:
##########
@@ -122,8 +121,9 @@ private StreamExecutionEnvironment createEnv(
env.setParallelism(p);
env.enableCheckpointing(100);
env.getCheckpointConfig()
- .setExternalizedCheckpointCleanup(
-
CheckpointConfig.ExternalizedCheckpointCleanup.RETAIN_ON_CANCELLATION);
+ .setExternalizedCheckpointCleanupRetention(
Review Comment:
+1, This is consistent with real config name.
BTW, I'd also suggest to rename the new class name to
`ExternalizedCheckpointRetention` or at least add some descriptions e.g. 'Also
called ExternalizedCheckpointRetention' in java doc and doc to link them for
the convinency of users.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
