laglangyue commented on code in PR #3186: URL: https://github.com/apache/flink-cdc/pull/3186#discussion_r1538466605
########## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/src/main/java/org/apache/flink/cdc/connectors/mysql/factory/MySqlDataSourceFactory.java: ########## @@ -93,6 +96,7 @@ public DataSource createDataSource(Context context) { String username = config.get(USERNAME); String password = config.get(PASSWORD); String tables = config.get(TABLES); + String tableExcludeList = config.get(TABLE_EXCLUDE_LIST); Review Comment: source.`tables` include more than one table , so it should be `tables.exclude`? ########## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/src/main/java/org/apache/flink/cdc/connectors/mysql/factory/MySqlDataSourceFactory.java: ########## @@ -93,6 +96,7 @@ public DataSource createDataSource(Context context) { String username = config.get(USERNAME); String password = config.get(PASSWORD); String tables = config.get(TABLES); + String tableExcludeList = config.get(TABLE_EXCLUDE_LIST); Review Comment: source.`tables` include more than one table , so it should be `tables.exclude`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org