XComp opened a new pull request, #24568:
URL: https://github.com/apache/flink/pull/24568

   ## What is the purpose of the change
   
   Hardens `TestingLeaderElection` to comply to the `LeaderContender` contract
   
   ## Brief change log
   
   * Notifying the contender of the leadership revocation should only happen if 
the leadership was actually confirmed
   * Revoking leadership in the `TestLeaderElection` should also reset the 
`confirmedLeaderInformation`
   * Added Preconditions to check for the right order of grant and revoke events
   * Updated the `LeaderContender` JavaDoc
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to