mxm commented on code in PR #24564:
URL: https://github.com/apache/flink/pull/24564#discussion_r1541028016
##########
flink-core/src/main/java/org/apache/flink/configuration/MetricOptions.java:
##########
@@ -277,11 +277,12 @@ public static Configuration forReporter(Configuration
configuration, String repo
* JobManager of an operator.
*/
public static final ConfigOption<String> SCOPE_NAMING_JM_OPERATOR =
- key("metrics.scope.jm-operator")
+ key("metrics.scope.coordinator")
Review Comment:
Do we want to move ahead with this change? If so, we should also change the
naming internally.
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/MetricStore.java:
##########
@@ -538,19 +556,19 @@ public TaskMetricStore getTaskMetricStore(String taskID) {
@ThreadSafe
public static class TaskMetricStore extends ComponentMetricStore {
private final Map<Integer, SubtaskMetricStore> subtasks;
- private final Map<String, ComponentMetricStore> jmOperators;
+ private final ComponentMetricStore jmOperator;
Review Comment:
Can't there be multiple coordinators per task? A task can host multiple
operators, each with their own coordinator. Is the idea to coalesce all of them
into one metric store?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
