iemre commented on code in PR #24598:
URL: https://github.com/apache/flink/pull/24598#discussion_r1546394926


##########
flink-runtime-web/web-dashboard/src/app/components/dagre/components/node/node.component.ts:
##########
@@ -165,7 +167,7 @@ export class NodeComponent {
     if (value === undefined || isNaN(value)) {
       return 'N/A';
     } else {
-      return `${value}%`;
+      return `${Math.round(value)}%`;

Review Comment:
   This will impact all metrics shown on the Job Graph vertex i.e. the 
backpressure and busy percentages. But I believe we should apply this to those 
metrics too, as otherwise we can see values like `99.99998%`. I don't believe 
we need that level of precision.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to