hugogu commented on code in PR #89:
URL:
https://github.com/apache/flink-connector-kafka/pull/89#discussion_r1555389033
##########
flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaSerializerWrapper.java:
##########
@@ -61,17 +61,12 @@ class KafkaSerializerWrapper<IN> implements
SerializationSchema<IN> {
this(serializerClass, isKey, Collections.emptyMap(), topicSelector);
}
- @SuppressWarnings("unchecked")
@Override
public void open(InitializationContext context) throws Exception {
- final ClassLoader userCodeClassLoader =
context.getUserCodeClassLoader().asClassLoader();
+ final ClassLoader userCodeClassLoader = selectClassLoader(context);
Review Comment:
Sure, removed.
##########
flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/reader/deserializer/KafkaValueOnlyDeserializerWrapper.java:
##########
@@ -55,17 +55,11 @@ class KafkaValueOnlyDeserializerWrapper<T> implements
KafkaRecordDeserialization
}
@Override
- @SuppressWarnings("unchecked")
public void open(DeserializationSchema.InitializationContext context)
throws Exception {
- ClassLoader userCodeClassLoader =
context.getUserCodeClassLoader().asClassLoader();
+ ClassLoader userCodeClassLoader = selectClassLoader(context);
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
