[ https://issues.apache.org/jira/browse/FLINK-5146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15690244#comment-15690244 ]
ASF GitHub Bot commented on FLINK-5146: --------------------------------------- Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2857 Overall, the changes and the tests look very good. There are some `TODO`s left in the code, what about those? > Improved resource cleanup in RocksDB keyed state backend > -------------------------------------------------------- > > Key: FLINK-5146 > URL: https://issues.apache.org/jira/browse/FLINK-5146 > Project: Flink > Issue Type: Improvement > Components: State Backends, Checkpointing > Reporter: Stefan Richter > Assignee: Stefan Richter > > Currently, the resources such as taken snapshots or iterators are not always > cleaned up in the RocksDB state backend. In particular, not starting the > runnable future will leave taken snapshots unreleased. > We should improve the releases of all resources allocated through the RocksDB > JNI bridge. -- This message was sent by Atlassian JIRA (v6.3.4#6332)