Jiabao-Sun commented on code in PR #24612:
URL: https://github.com/apache/flink/pull/24612#discussion_r1565204190
##########
flink-core/src/test/java/org/apache/flink/configuration/ConfigurationConversionsTest.java:
##########
@@ -52,7 +51,9 @@ public class ConfigurationConversionsTest {
private Configuration pc;
- @Before
+ @Parameter private TestSpec testSpec;
+
+ @BeforeEach
public void init() {
Review Comment:
The visibility of class and methods can be package default.
##########
flink-core/src/test/java/org/apache/flink/configuration/FilesystemSchemeConfigTest.java:
##########
@@ -21,83 +21,75 @@
import org.apache.flink.core.fs.FileSystem;
import org.apache.flink.core.fs.UnsupportedFileSystemSchemeException;
import org.apache.flink.core.fs.local.LocalFileSystem;
-import org.apache.flink.util.TestLogger;
-import org.junit.After;
-import org.junit.Rule;
-import org.junit.Test;
-import org.junit.rules.TemporaryFolder;
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.io.TempDir;
-import java.io.IOException;
+import java.io.File;
import java.net.URI;
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertNotNull;
-import static org.junit.Assert.assertNull;
-import static org.junit.Assert.assertTrue;
-import static org.junit.Assert.fail;
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
/** Tests for the configuration of the default file system scheme. */
-public class FilesystemSchemeConfigTest extends TestLogger {
+public class FilesystemSchemeConfigTest {
- @Rule public final TemporaryFolder tempFolder = new TemporaryFolder();
+ @TempDir public File tempFolder;
Review Comment:
private
##########
flink-core/src/test/java/org/apache/flink/configuration/ConfigurationParsingInvalidFormatsTest.java:
##########
@@ -64,35 +66,35 @@ public static Object[][] getSpecs() {
};
}
- @Parameterized.Parameter public ConfigOption<?> option;
+ @Parameter public ConfigOption<?> option;
Review Comment:
visibility can be private.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
