1996fanrui commented on code in PR #814:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/814#discussion_r1566801016
##########
flink-autoscaler-standalone/src/main/java/org/apache/flink/autoscaler/standalone/JobListFetcher.java:
##########
@@ -19,12 +19,19 @@
import org.apache.flink.annotation.Experimental;
import org.apache.flink.autoscaler.JobAutoScalerContext;
+import org.apache.flink.configuration.Configuration;
import java.util.Collection;
/** The JobListFetcher will fetch the jobContext of all jobs. */
@Experimental
public interface JobListFetcher<KEY, Context extends
JobAutoScalerContext<KEY>> {
- Collection<Context> fetch() throws Exception;
+ /**
+ * Fetch the job context.
+ *
+ * @param baseConf The basic configuration for standalone autoscaler. The
basic configuration
+ * can be overridden by the configuration at job-level.
+ */
+ Collection<Context> fetch(Configuration baseConf) throws Exception;
Review Comment:
This PR updated this `fetch` interface: adding a `baseConf` as the basic
configuration.
Hi @gyfora , would you mind helping take a look this PR in your free time?
thanks~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
