twalthr commented on code in PR #24661:
URL: https://github.com/apache/flink/pull/24661#discussion_r1570166387
##########
flink-table/flink-table-runtime/src/test/java/org/apache/flink/table/formats/raw/RawFormatSerDeSchemaTest.java:
##########
@@ -197,12 +247,12 @@ public static TestSpec type(DataType fieldType) {
return new TestSpec(fieldType);
}
- public TestSpec value(Object value) {
- this.value = value;
+ public TestSpec values(Object[] values) {
Review Comment:
make this a var arg to avoid the need for `new X[]{}` in the test specs.
this will improve code readibility.
##########
flink-table/flink-table-runtime/src/test/java/org/apache/flink/table/formats/raw/RawFormatSerDeSchemaTest.java:
##########
@@ -197,12 +247,12 @@ public static TestSpec type(DataType fieldType) {
return new TestSpec(fieldType);
}
- public TestSpec value(Object value) {
- this.value = value;
+ public TestSpec values(Object[] values) {
+ this.values = values;
return this;
}
- public TestSpec binary(byte[] bytes) {
+ public TestSpec binary(byte[][] bytes) {
Review Comment:
same as above, make this a var arg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
